Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Auth needed in NextJS (Frontend) #381

Open
rajraj889 opened this issue Oct 1, 2021 · 7 comments · May be fixed by #482
Open

Github Auth needed in NextJS (Frontend) #381

rajraj889 opened this issue Oct 1, 2021 · 7 comments · May be fixed by #482
Labels
feature New feature or request NextJS Frontend/Next related work
Milestone

Comments

@rajraj889
Copy link
Member

Feature Request

Is your feature request related to an existing Issue or a new implementation?

New Implementation

Feature Description

GitHub auth needed for frontend and backend, basic fields required are as implemented in platform auth,
reference code for GitHub auth, already present in react v1.

Possible Solution

Additional context

@rajraj889 rajraj889 added feature New feature or request hacktoberfest NextJS Frontend/Next related work labels Oct 1, 2021
@rajraj889 rajraj889 added this to the V2 milestone Oct 1, 2021
@GeoBrodas
Copy link

Hey @rajraj889 I can implement this using NextAuth package, do you want me to give it a try? Could you tell me which pages you want to protect?

@RusherRG
Copy link
Member

RusherRG commented Oct 2, 2021

@GeoBrodas If you don't mind it would be great if you could wait for a day until issues #336 #374 get resolved so then you'll have some boilerplate code to work with. Although, feel free to make an independent component that can be merged easily. If you want to get started, let us know we'll assign you the issue.

@McTechie
Copy link
Contributor

McTechie commented Oct 2, 2021

Also as mentioned in the issue... the reference code for adding GitHub auth already exists in FrontEndApp/v1-react. It would be great if you could try implementing with the same! 😄

cc: @therajtiwari

@GeoBrodas
Copy link

Alrighto I'll give it my best shot! Probably wait for it too, do let me know ✌🏼

@GeoBrodas
Copy link

Any updates??

@rajraj889
Copy link
Member Author

@GeoBrodas thanks for your patience, we had some things which took longer than expected. You can go ahead and start working on this issue, till that time i think both those issues will be done. Actually we are integrating redux with auth so you will have to follow similar things which will be done in those issues above. :)

@rajraj889
Copy link
Member Author

@GeoBrodas you can also look at #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request NextJS Frontend/Next related work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants