Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add release drafter #413

Closed
wants to merge 9 commits into from
Closed

feat: Add release drafter #413

wants to merge 9 commits into from

Conversation

Aniket-508
Copy link

Pull Request

What does this PR do?

Fixes #357

What part does this affect?

  • FrontEnd.
  • BackEnd.
  • Documentation.
  • Other. (Please specify below)
  • Added Release Drafter by configuring a YAML-based workflow file at .github/workflows/release-drafter.yml which drafts the next release notes as pull requests are merged into the main branch.
  • Added Update Changelog by configuring a YAML-based workflow file at .github/workflows/update-changelog.yml which also drafts the new versions keeping previous version changes in changelog.md file.
  • Also added the required labels that were provided by repo maintainers under appropriate titles.

Before submitting

  • Was this discussed/approved via a GitHub issue or slack?
  • Did you read the contributor guideline?
  • Did you ensure that there aren't any other open Pull Requests for the same update/change?
  • Did you make sure the title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure the code is clean and docstrings have been added or updated as required?
  • Did you make sure the code is linted/formatted locally prior to submission? (using black and/or prettier)
  • Did you make sure to update the documentation with your changes? (if necessary)

PR review

Anyone in the community is free to review the PR once the tests have passed.

Thank you for contributing to AutoDL. We look forward to your continued support.

@Aniket-508
Copy link
Author

@RusherRG @bamblebam Pls check this out !!

RusherRG
RusherRG requested changes Oct 4, 2021
View reviewed changes
Copy link
Member

@RusherRG RusherRG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aniket-508. This looks good to me except for some minor changes. I am not sure how we can test this out without merging it. Probably one way could be to have the same PR created on Auto-DL/Recommendation-System and check how it works there as we had discussed earlier @ADI10HERO

.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
.github/workflows/update-changelog.yml Outdated Show resolved Hide resolved
@Aniket-508
Copy link
Author

@RusherRG I have made suggested changes and also raised a pull request against it in Recommendation System.

@ADI10HERO
Copy link
Member

@Aniket-508 If I am reading it correctly, the drafter is triggered on every push on main?

@Aniket-508
Copy link
Author

@ADI10HERO Yes

@RusherRG
Copy link
Member

@Aniket-508 make the changes that you had made in Auto-DL/Recommendation-System#25 and Auto-DL/Recommendation-System#26. And once we test it, we can merge this.

@Aniket-508
Copy link
Author

@RusherRG There are no changes in this pull request unlike the recommendation one because the config file by default is release-drafter.yml but there since I had given file name as release_drafter.yml I had to separately in the corresponding workflow file.

RusherRG
RusherRG requested changes Oct 19, 2021
View reviewed changes
.github/release-drafter.yml Outdated Show resolved Hide resolved
@Aniket-508
Copy link
Author

@RusherRG Is it ok now?

@RusherRG
Copy link
Member

RusherRG commented Oct 20, 2021 •
edited

@ADI10HERO should we merge this? Or try all the combinations of labels and see the releases drafted on https://github.com/Auto-DL/Recommendation-System first and then merge this

@ADI10HERO
Copy link
Member

Hey, @RusherRG and @Aniket-508 we'd like to wait for the Recommendation-System release drafter.
As labeled "hacktoberfest-accepted" it'll be counted towards hacktoberfest :)

@ADI10HERO
Copy link
Member

Closing now, we'll re-open when needed

@ADI10HERO ADI10HERO closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RusherRG RusherRG RusherRG requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release drafter
3 participants
@Aniket-508 @ADI10HERO @RusherRG