refactor: Add log messages for BackEndApp/v1 #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajwalnayak7
changed the title
RusherRG
requested changes
Oct 5, 2021
RusherRG
reviewed
Oct 5, 2021
| @@ -37,7 +39,9 @@ def generate(request): | |||
| project_id = request.data.get("project_id") | |||
| store_obj = Store(user) | |||
| if not store_obj.exist(project_id): | |||
| raise Exception("No such project exists") | |||
| error_message = "No such project exists" | |||
| logger.error(f"[API][POST][generate] {error_message}") | |||
There was a problem hiding this comment.
[API][POST][generate]
Is this supposed to resolve to some string?
There was a problem hiding this comment.
Nope. It is a more structured way of logging. This will help in debugging (ex: filtering logs in the shell using grep).
There was a problem hiding this comment.
Could rather have a message like the above?
2021-10-06 06:19:23 | v1.views/get_all_projects | INFO: "POST /v1/projects/all/ HTTP/1.1" Fetching all projects for 'test_user'
There was a problem hiding this comment.
@prajwalnayak7 could you make the necessary changes?
12 tasks
|
@prajwalnayak7 It would be great if you could alter the log messages to look like the one mentioned by @RusherRG in this discussion |
|
Hey @prajwalnayak7 closing the PR due to no activity. Please check the slack message in the #announcements channel for more info. Thanks for your contributions! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #337
-->
What part does this affect?
Before submitting
blackand/orprettier)PR review
Anyone in the community is free to review the PR once the tests have passed.
Thank you for contributing to AutoDL. We look forward to your continued support.