Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code unit test #332

Open
ADI10HERO opened this issue Sep 14, 2021 · 2 comments
Open

Generate code unit test #332

ADI10HERO opened this issue Sep 14, 2021 · 2 comments
Labels
django Backend/Django related work feature New feature or request

Comments

@ADI10HERO
Copy link
Member

Feature Request

Is your feature request related to an existing Issue or a new implementation?
Nope

Feature Description

A simple unit test that checks if the required code file is generated.

A really helpful test would be to test failing on absence of required parameters (would need to do some PnC to get the required ones though)

@ADI10HERO ADI10HERO added feature New feature or request django Backend/Django related work labels Sep 14, 2021
@kyteinsky
Copy link

Hello, I would like to work on this, but I am not sure which file is referred to as "required code file".
And some more details would be appreciated regarding "PnC" and "required parameters".

Thanks.

@ADI10HERO
Copy link
Member Author

Hey @kyteinsky,
Required code is the file generated when Auto-DL is run successfully.
As it's generated in runtime, not available in the repo.

It may look easy but it isn't an easy issue tbh. 😅

Currently when the /generate route is called some parameters are required for it to be generated successfully. If they are not provided, some trivial error is printed ("Some error occurred") so a unit test for the same is needed, and with that test (test-driven-development) we'll enforce the required parameters so that improved error logging can be done on Auto-DL's side itself before calling the generate (code) "function".

The aim here is to identify the required parameters and provide test cases that will help the developers and future users of Auto-DL. With respect to PnC (permutations and combinations), I meant that there's no list of "required" parameters, ofc, some are obvious, but we need to try sending and not sending parameters to find out whether a particular param is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Backend/Django related work feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants