Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern for UUID #79

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Pattern for UUID #79

merged 1 commit into from
Jun 10, 2020

Conversation

ViniciusFXavier
Copy link
Collaborator

I decided to make this pattern in order to support UUID, I have implemented the regex and added the new pattern to the tests and to documentation.

closes #78

@mattwelke
Copy link
Collaborator

mattwelke commented Jun 5, 2020

@ViniciusFXavier This looks useful. We should name it a v4uuid check though instead of uuid to be more specific.

@mattwelke
Copy link
Collaborator

@ViniciusFXavier If you edit this PR we can merge it and release a new minor version.

@ViniciusFXavier
Copy link
Collaborator Author

@mattwelke I made the adjustment and I adjusted a little indentation error.

I decided to make this pattern in order to support uuid, I implemented the regex and added the new pattern to the tests and the documentation

closes #78
Copy link
Contributor

@lfreneda lfreneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks useful 👯

@mattwelke mattwelke merged commit f4740bc into schema-inspector:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion - New pattern for UUID
3 participants