Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues #73

Open
JakobJingleheimer opened this issue May 7, 2021 · 0 comments
Open

Accessibility issues #73

JakobJingleheimer opened this issue May 7, 2021 · 0 comments

Comments

@JakobJingleheimer
Copy link

JakobJingleheimer commented May 7, 2021

Loving the documentation so far (especially the emojis).

But the docs site clips in a lot of places when adhering to WCAG 2.x AA font-size criteria.

Also, the left sidebar/table of contents is HUGE: ⅓ the total viewport width, and about ½ of the sidebar is empty space (because its width is set to an explicit, arbitrary width of 20em). This could be resolved by simply setting width: fit-content (or not setting anything at all). The rest of the site doesn't automatically adapt to use that newly available space because of various position: fixeds. Flexbox would resolve this (in a much more accessible and responsive way, with much, much less code):

html,
body,
#app,
.theme-container
{
  height: 100%;
  overflow: hidden;
}

main {
  max-height: 100%;
  overflow-y: auto;
}

.theme-container {
  display: flex;
  flex-direction: row;
  flex-wrap: wrap;
}

.navbar {
  display: flex;
  flex: none;
  width: 100%;
}

.sidebar,
main
{
  max-height: 100%;
  overflow-y: auto;
}

main { flex: 1 }

The above styles assume the various position: fixed and related properties have been removed. Also, much of those styles should be wrapped in a screen media-query to avoid print issues.

Before:
site before: sidebar is huge with empty space, multiple pieces of content are clipped

After:
site after: sidebar sizes to its contents, available space is used

The flexbox approach is also generally favourable because switching from desktop to mobile is often little more than flex-direction: column → row.

I'd be happy to send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant