Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts: incorrect typing for validate function #28

Open
jzabinski-dolios opened this issue Dec 23, 2021 · 0 comments
Open

index.d.ts: incorrect typing for validate function #28

jzabinski-dolios opened this issue Dec 23, 2021 · 0 comments

Comments

@jzabinski-dolios
Copy link

jzabinski-dolios commented Dec 23, 2021

For the validate function, index.d.ts declares:

validate(): void;

Here is the relevant code from index.js:

WasmModule.prototype.validate = function (options) {
var features = new Features(options || ({}));

index.d.ts is missing a description of the options parameter. Ferreting around in the code, it looks like elsewhere in index.d.ts, WasmFeatures is defined, which seems to be intended to match the WebAssembly feature list described here.

I think that index.d.ts should say:

validate(options?: WasmFeatures): void;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant