Fix some resolver bugs #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for PR! You should remove (discard) |
|
@MaxGraey done |
dcodeIO
reviewed
Jun 22, 2019
|
I think the package-lock differences happen between different environments, and just keeping it as it is helps to reduce some of the noise. Can you reset it? Other than that, LGTM with the comments resolved :) |
dcodeIO
reviewed
Jun 22, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a certain type of bug in the resolver which is caused by primitive types not having
classReference. More specifically, this PR fixes #680. However, there are some cases, especially those involve operators, are left untouched, so #473 remains open.