Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env:abort function stub for wasm's import in template for asinit script #670

Merged
merged 1 commit into from Jun 19, 2019
Merged

Add env:abort function stub for wasm's import in template for asinit script #670

merged 1 commit into from Jun 19, 2019

Conversation

MaxGraey
Copy link
Member

No description provided.

@MaxGraey MaxGraey requested a review from dcodeIO June 15, 2019 12:45
@dcodeIO
Copy link
Member

dcodeIO commented Jun 15, 2019

Maybe we can even go a bit further here and use the loader, so everyone has its functionality out of the box. Wdyt?

@MaxGraey
Copy link
Member Author

I think better use some prompt and allow user to choose loader or existing simple boilerplate code.

@MaxGraey
Copy link
Member Author

I worry when loader would include by default we lost status of glue-free wasm language =)

@dcodeIO
Copy link
Member

dcodeIO commented Jun 15, 2019

Hmm. Chances are that someone using asinit the first time doesn't know an answer to this question yet. What if the the index file would have both loader.instantiate and WebAssembly.instantiate, with the loader being the default and the other being commented out, plus a short sentence what commenting out one and uncommenting the other does?

@MaxGraey
Copy link
Member Author

MaxGraey commented Jun 15, 2019

Or just include link to documentation for loader with more advanced examples. As an other option

@MaxGraey
Copy link
Member Author

Could we merge this as temporary solution?

@dcodeIO dcodeIO merged commit 4802a0a into AssemblyScript:master Jun 19, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Jun 19, 2019

Sure :)

@MaxGraey MaxGraey deleted the improve-asinit branch June 19, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants