Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make String toUTF8 and fromUTF8 more ergonomic #591

Closed
bowenwang1996 opened this issue May 15, 2019 · 3 comments
Closed

make String toUTF8 and fromUTF8 more ergonomic #591

bowenwang1996 opened this issue May 15, 2019 · 3 comments
Labels
duplicate stale

Comments

@bowenwang1996
Copy link
Contributor

Right now toUTF8 returns a pointer and fromUTF8 takes a pointer and length of the underlying array. It seems more ergonomic to have toUTF8 return something of an array type, such as Uint8Array, and have fromUTF8 take an array as argument.
@MaxGraey
Copy link
Member

See reworked api proposal: #564

@stale
Copy link

stale bot commented Jun 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 15, 2019
@MaxGraey
Copy link
Member

MaxGraey commented Jun 22, 2019 •
edited

Was improved in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcodeIO @MaxGraey @bowenwang1996