Do not allocate MemorySegments for memory.data(i32, i32?) #2831
Conversation
|
Would this perhaps become simpler if we'd keep tracking such segments as More generally, when not indicating the presence of the segment to Binaryen, we'd always have to assume that memory is zeroed, as the zeroes won't be in the |
Oh, that's...a much better idea. Thanks and sorry about that. |
CountBleck
force-pushed
the
fix-large-memory-crash
branch
from
373166c
to
6a89a09
Compare
@dcodeIO hmm, would this conflict when |
CountBleck
force-pushed
the
fix-large-memory-crash
branch
3 times, most recently
from
ed50aef
to
4465767
Compare
MemorySegments can now hold null buffers, which signifies that memory is in fact used in the compiled program, for programs that only reserve zero-filled memories. Using null buffers avoids passing zero-filled buffers to Binaryen, which isn't necessary since Wasm memories are initialized with zeroes when a (data ...) segment isn't present. This change is breaking in that modules using imported memories that contain non-zero values in such memory ranges at the time of instantiation will retain those values, as opposed to being filled. This shouldn't affect most users, however, and it could possibly be desirable. Fixes AssemblyScript#2827.
CountBleck
force-pushed
the
fix-large-memory-crash
branch
from
4465767
to
163a631
Compare
|
@HerrCai0907 I changed the commit message; this is technically a breaking change. |
You can modify it when click squash and merge😆 . Actually the message in commit is meaningless. |
Fixes #2827.
Changes proposed in this pull request:
⯈ Bump
Compiler#memoryOffsetinstead of allocating zero-filled segments.There is an issue with the
initialPagescalculation ininitDefaultMemory, however. The existing condition to run that calculation depends onmemorySegments.length, which is now zero if onlymemory.data(n: i32)is called, as in the memory-config-errors test.Making that calculation occur regardless of the number of memory segments would cause a separate issue: due to the default memory offsets of
options.memoryBase,1024, or8, modules that previously compiled with an initial memory of 0 pages would compile with a minimum of 1 page.