Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect variable resolving for class default initializer #2791

Closed
wants to merge 3 commits into from

Conversation

HerrCai0907
Copy link
Member

@HerrCai0907 HerrCai0907 commented Nov 14, 2023

Introducing new default constructor to avoid name conflict when do default initializer.
fixes: #2790

Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review in depth at the moment (I've got overdue homework and all), but why does this PR touch so many fixtures?

@HerrCai0907
Copy link
Member Author

I can't review in depth at the moment (I've got overdue homework and all), but why does this PR touch so many fixtures?

It introduce new default constructor

@CountBleck
Copy link
Member

It introduce new default constructor

I don't follow. Isn't this just an issue with scoping?

@HerrCai0907 HerrCai0907 marked this pull request as draft November 14, 2023 04:44
@HerrCai0907 HerrCai0907 deleted the fix-class-init branch November 14, 2023 05:37
@HerrCai0907 HerrCai0907 restored the fix-class-init branch November 17, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect variable resolving for class default initializer
2 participants