fix: improve diagnose for invalid generic function call #2781
Conversation
There was a problem hiding this comment.
Arguably, this seems like a hack, since it's special-casing those sets of tokens.
Also, a<12345>() is valid TS, since 12345 is a type (but we don't support that!).
The proper fix would be implementing the typeof syntax in types (with a "Not yet implemented" diagnostic).
Also, TS seems to dislike this bit of code, but this patch would erroneously treat it as a call to a generic function.
we will try to parser it as generic function call, and than treat it as comparison. If both patterns aren't matched, than we need to do some hack and guess what is the actual intention. |
This code will not match this pattern. It only match empty parentheses and it is definitely not a comparison. |
Original implement treat invalid generic function call
Expr '<' Expr '>' '(' ')'as less than and greater expression.This patch detect it and throw "expect type" diagnose.
Fixes #2780