Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crono not maintaned - CVE-2020-26235 in time #109

Closed
acim opened this issue Oct 11, 2021 · 2 comments
Closed

crono not maintaned - CVE-2020-26235 in time #109

acim opened this issue Oct 11, 2021 · 2 comments

Comments

@acim
Copy link

acim commented Oct 11, 2021

crono depends on vulnerable version of time and it seems not to be well maintained. Could you maybe replace it completely with some newer version of time as suggested here.

@Arnavion
Copy link
Owner

We can continue discussing in kube-rs/kube#650 to keep the conversation in one place.

Arnavion added a commit that referenced this issue Oct 12, 2021
Arnavion added a commit that referenced this issue Oct 28, 2021
@Arnavion
Copy link
Owner

v0.14.0 has been released with default features disabled, as discussed in kube-rs/kube#650 (comment) This means that time 0.1 is already not pulled in by default. And if chrono ever removes chrono::Local or puts it behind a feature, that too will not be pulled in by default, without needing any change in k8s-openapi.

I'm not planning on replacing chrono with time completely at this time, unless there is more reason to. time resolved the vuln first by making the local time API fail unconditionally, and now by making it fail if it cannot determine that there's only one thread in the process. In my opinion this is going too far for what is reasonable for a library, especially since the trigger for this vuln is such an uncommon thing in the first place.

For posterity, this branch has the change for such a switch in case I change my mind in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants