Skip to content

Add SQL sqrt Function with Tests #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add SQL sqrt Function with Tests #890

merged 1 commit into from
Mar 1, 2023

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Feb 23, 2023

What does this PR do?

These changes add a SQL square root function sqrt().
Practically, this is function is based on the abs() function. Furthermore, square roots of negative numbers return null, to avoid an error.

Motivation

I think, this function is useful as it is one of the very few math functions
in the Enterprise Java Beans Query Language (EJB-QL).

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

Sorry, something went wrong.

@lvca lvca merged commit e8f512f into ArcadeData:main Mar 1, 2023
@lvca lvca self-requested a review March 1, 2023 02:19
@lvca lvca added this to the 23.2.1 milestone Mar 1, 2023
@lvca lvca added the enhancement New feature or request label Mar 1, 2023
@gramian gramian deleted the sqrt branch April 7, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants