StrictMode disk read violations #211
Comments
|
Hi @akravch , Apologies for the long lead time after the holidays in responding. We have several background thread strategies in the SDK and moving these calls to utilize them shouldn't be too difficult. We will update this issue once a fix is available/released. |
|
Hi @arlindiDev , SDK 19.0.0 directly addresses the ANR issues in the SDK. However, the kotlin coroutine issue (Kotlin/kotlinx.coroutines#3180) our team raised is still present so depending on your version of kotlin coroutines you still may continue to see issues. |
|
Hi @akravch , Please update your kotlin coroutine version to 1.6.1+ and Braze Android 19.0.0+ to resolve the issue. See Kotlin/kotlinx.coroutines#3180 for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Standard Reporting
What version of the Braze Android SDK are you using?
It has initially occurred in Xamarin bindings version 1.21.0, which binds to Braze Android SDK v13.0.0, but also reproducible on the native Android SDK v17.0.0.
What did you do?
Enabled StrictMode in my Xamarin app, then did the same on the
com.braze.firebasepushsample from this repository.What did you expect to happen?
No StrictMode errors when opening the app clicking on a push notification message.
What happened instead?
A bunch of StrictModeDiskReadViolation errors like the following logged:
All errors
The disk reads take about 150 ms each in the sample app. In my production app they take up to 400 ms, probably because the app is heavier overall and utilizes disk from its side too.
I believe it can cause performance issues and even ANRs in some cases. Actually, there are even more scenarios of disk reads from the main thread, e.g. triggered by the
BrazeActivityLifecycleCallbackListenerin runtime, or simple calls toBraze.getInstancewhen performed from the main thread. Although those specific ones I mentioned above concern me more as they can slow down the app start, it would be really great to get rid of all of them, perhaps providing an async API that would delegate disk accesses to background threads.Steps to reproduce
FirebaseApplicationwithin thecom.braze.firebasepushsampleStrictMode.setThreadPolicy(new StrictMode.ThreadPolicy.Builder().detectAll().penaltyLog().build());into theonCreatemethodAre you doing any feature customizations that may relate to the issue? Can you share the code snippet?
Only enabling StrictMode as described above.
Project that demonstrates the issue
https://github.com/Appboy/appboy-android-sdk/tree/master/samples/firebase-push
ANR Reporting
We do have ANRs occurred in
NotificationTrampolineActivityandBrazePushReceiver, although there are no stack traces attached, so I cannot confidently say that the disk reads are the reason.The text was updated successfully, but these errors were encountered: