Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1029 add emptyTagsToSelfClosing option to xhtml formatter #1031

Conversation

Aizeren
Copy link
Contributor

@Aizeren Aizeren commented Dec 23, 2021

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Add emptyTagsToSelfClosing option to XhtmlMarkupFormatter
Resolve #1029

@Aizeren Aizeren changed the title Feature/#1029 add option to xhtml formatter Feature/#1029 add emptyTagsToSelfClosing option to xhtml formatter Dec 23, 2021
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl added this to the 0.17.0 milestone May 30, 2022
@FlorianRappl FlorianRappl merged commit 55165c6 into AngleSharp:devel May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to XhtmlMarkupFormatter for not to make empty elements self-closing
2 participants