Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
Fix #1019
This PR change behavior of
Url.Hash
andUrl.Search
setter.Url.Hash
value
is null or empty, setter assignFragment
tonull
.value
starts with '#', setter assignFragment
tovalue.Substring(1)
.Fragment
tovalue
.Url.Search
value
is null or empty, setter assignQuery
tonull
.value
starts with '?', setter assignQuery
tovalue.Substring(1)
.Query
tovalue
.Browser's JavaScript behavior
I verified it on https://kzrnm.github.io/work/location.html
Chrome
Url.Hash
value
is null or empty, setter assignFragment
to""
.value
starts with '#', setter assignFragment
tovalue.Substring(1)
.Fragment
tovalue
.Url.Search
value
is null or empty, setter assignQuery
to""
.value
starts with '?', setter assignQuery
tovalue.Substring(1)
.Query
tovalue
.Firefox
Url.Hash
value
is null or empty, setter assignFragment
to""
.value
starts with '#', setter assignFragment
tovalue.Substring(1)
.Fragment
tovalue
.Url.Search
value
is null or empty, setter assignQuery
tonull
.value
starts with '?', setter assignQuery
tovalue.Substring(1)
.Query
tovalue
.location.Mozilla.Firefox.2021-12-07.19-50-16.mp4