Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC1123Pattern format #1018

Merged
merged 1 commit into from Dec 6, 2021

Conversation

kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Dec 6, 2021

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

CookieHandlingTests.MissingCookie_Issue768 depend on culture "en-US" because DateTime.ToString is culture aware.

DateTime.ToString("R") creates RFC1123 format string regardless of culture.

https://docs.microsoft.com/en-us/dotnet/standard/base-types/standard-date-and-time-format-strings?redirectedfrom=MSDN#RFC1123

CultureInfo.CurrentCulture = CultureInfo.GetCultureInfo("ja");

// 月, 06 12月 2021 12:37:43 GMT
Console.WriteLine($"{DateTime.UtcNow.AddHours(1).ToString("ddd, dd MMM yyyy HH:mm:ss")} GMT");

// Mon, 06 Dec 2021 12:37:43 GMT
Console.WriteLine($"{DateTime.UtcNow.AddHours(1):R}");

@FlorianRappl FlorianRappl added this to the 0.17.0 milestone Dec 6, 2021
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl merged commit 9315e87 into AngleSharp:devel Dec 6, 2021
@kzrnm kzrnm deleted the feature/RFC1123Pattern branch December 6, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants