Handle prefix as generic.FormMixin does #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using forms rendered as modals on a larger page, it is convenient
to use form prefixes passed by GET parameter.
Using the `get_prefix` method then allows us to return and handle the
prefix correctly:
```python
class PrefixedFormMixin(generic.edit.FormMixin):
def get_prefix(self):
return self.request.GET.get('prefix', self.prefix)
```
Ref:
http://ccbv.co.uk/projects/Django/1.11/django.views.generic.edit/FormMixin/#get_prefix
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 53.99% 54.06% +0.07%
==========================================
Files 6 6
Lines 526 529 +3
Branches 62 62
==========================================
+ Hits 284 286 +2
- Misses 222 223 +1
Partials 20 20
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using forms rendered as modals on a larger page, it is convenient
to use form prefixes passed by GET parameter.
Using the
get_prefixmethod then allows us to return and handle theprefix correctly:
Ref:
http://ccbv.co.uk/projects/Django/1.11/django.views.generic.edit/FormMixin/#get_prefix