Fix build on latest nightly #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm! is now stable.
bjorn3
reviewed
Dec 19, 2021
| @@ -5,6 +5,8 @@ | |||
| // http://opensource.org/licenses/MIT>, at your option. This file may not be | |||
| // copied, modified, or distributed except according to those terms. | |||
|
|
|||
| #[cfg(all(feature = "nightly", any(target_arch = "x86", target_arch = "x86_64")))] | |||
There was a problem hiding this comment.
Maybe rename the feature to "hardware-lock-elision" now or in a future release?
There was a problem hiding this comment.
In a future version I will just have this always enabled by default.
There was a problem hiding this comment.
Don't some processors have a bug causing "unpredictable system behavior" (aka crashes or worse) when using hardware lock elision?
There was a problem hiding this comment.
That's actually a good point, I wasn't aware that HLE was broken on all currently available CPUs.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asm! is now stable.