Disable eventual fairness on wasm32-unknown-unknown #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
reviewed
Oct 31, 2021
std::time::Instant panics on this target and the external instant crate adds undesirable external dependencies to the wasm module.
Amanieu
force-pushed
the
wasm-fair-timeout
branch
from
f9e45fb
to
3fd2ce4
Compare
|
FWIW, I think it only adds undesirable external dependencies if your host is not a browser. If you target the browser you can configure it and enable features and it compiles just fine. But it's a good idea to just remove this for wasm32 all together if it's not strictly needed. |
facebook-github-bot
pushed a commit
to facebookexperimental/reverie
that referenced
this pull request
Feb 7, 2022
Summary: ~~~Added new parking-lot version named parking_lot_0_12~~~ allow-large-files previous versions of parking-lot are incompatible with wasm compilation targets rustwasm/wasm-bindgen#2160 Amanieu/parking_lot#302 Reviewed By: dtolnay Differential Revision: D33985872 fbshipit-source-id: ce571ef50289fe97ff89dbf72d2c7f39fbd47758
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Feb 7, 2022
Summary: ~~~Added new parking-lot version named parking_lot_0_12~~~ allow-large-files previous versions of parking-lot are incompatible with wasm compilation targets rustwasm/wasm-bindgen#2160 Amanieu/parking_lot#302 Reviewed By: dtolnay Differential Revision: D33985872 fbshipit-source-id: ce571ef50289fe97ff89dbf72d2c7f39fbd47758
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Feb 7, 2022
Summary: ~~~Added new parking-lot version named parking_lot_0_12~~~ allow-large-files previous versions of parking-lot are incompatible with wasm compilation targets rustwasm/wasm-bindgen#2160 Amanieu/parking_lot#302 Reviewed By: dtolnay Differential Revision: D33985872 fbshipit-source-id: ce571ef50289fe97ff89dbf72d2c7f39fbd47758
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 7, 2022
Summary: ~~~Added new parking-lot version named parking_lot_0_12~~~ allow-large-files previous versions of parking-lot are incompatible with wasm compilation targets rustwasm/wasm-bindgen#2160 Amanieu/parking_lot#302 Reviewed By: dtolnay Differential Revision: D33985872 fbshipit-source-id: ce571ef50289fe97ff89dbf72d2c7f39fbd47758
1 task
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::time::Instant panics on this target and the external instant crate
adds undesirable external dependencies to the wasm module.
Fixes #269