Add arc_lock feature, with guards that can be accessed from inside of Arc #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Jul 30, 2021
lock_api/src/mutex.rs
Outdated
| /// `Arc` and the resulting mutex guard has no lifetime requirements. | ||
| #[cfg(feature = "arc_lock")] | ||
| #[inline] | ||
| pub fn try_lock_for_arc(this: &Arc<Self>, timeout: R::Duration) -> Option<ArcMutexGuard<R, T>> { |
There was a problem hiding this comment.
try_lock_arc_for sounds better here.
lock_api/src/mutex.rs
Outdated
| /// an `Arc` and the resulting mutex guard has no lifetime requirements. | ||
| #[cfg(feature = "arc_lock")] | ||
| #[inline] | ||
| pub fn try_lock_until_arc( |
lock_api/src/mutex.rs
Outdated
| @@ -583,6 +658,112 @@ impl<'a, R: RawMutex + 'a, T: fmt::Display + ?Sized + 'a> fmt::Display for Mutex | |||
| #[cfg(feature = "owning_ref")] | |||
| unsafe impl<'a, R: RawMutex + 'a, T: ?Sized + 'a> StableAddress for MutexGuard<'a, R, T> {} | |||
|
|
|||
| /// An RAII mutex guard returned by the `Arc` locking operations on `Mutex`. This is similar to the `MutexGuard` | |||
There was a problem hiding this comment.
Split the first sentence into a separate paragraph. This summary is shown in the module documentation index.
lock_api/src/mutex.rs
Outdated
| /// and the resulting mutex guard has no lifetime requirements. | ||
| #[cfg(feature = "arc_lock")] | ||
| #[inline] | ||
| pub fn lock_arc(this: &Arc<Self>) -> ArcMutexGuard<R, T> { |
There was a problem hiding this comment.
Suggested change
| pub fn lock_arc(this: &Arc<Self>) -> ArcMutexGuard<R, T> { | |
| pub fn lock_arc(self: &Arc<Self>) -> ArcMutexGuard<R, T> { |
You can use self here which allows lock_arc to be called with dot syntax.
|
Great work! Can you update the CI script so that the |
|
It doesn't seem like you can use |
|
It's fine I'll just bump the MSRV for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #273.
This adds guards for
MutexandRwLockthat allow it to be used from inside of anArc, without lifetime hurdles.