Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD returns EINVAL in the same way as DragonFlyBSD. #270

Merged
merged 3 commits into from Dec 21, 2020
Merged

OpenBSD returns EINVAL in the same way as DragonFlyBSD. #270

merged 3 commits into from Dec 21, 2020

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Dec 19, 2020

Without this, cargo test fails on OpenBSD -current. I suspect all the BSDs have the same behaviour in this regard, but I don't have the ability to test FreeBSD or NetBSD I'm afraid.

@Amanieu
Copy link
Owner

Amanieu commented Dec 21, 2020

I think we should just get rid of the if and always use the first variant. It's not really essential anyways.

@ltratt
Copy link
Contributor Author

ltratt commented Dec 21, 2020

I agree -- the two new commits do that. I'm happy to squash them down to one if you'd prefer.

@Amanieu Amanieu merged commit 02eaa63 into Amanieu:master Dec 21, 2020
@Amanieu
Copy link
Owner

Amanieu commented Dec 21, 2020

Thanks!

@ltratt ltratt deleted the openbsd_too branch December 21, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants