core: Use a weaker dependency on smallvec. #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smallvec 1.4 regresses performance in Firefox, so while we fix it it'd be nice to be able to not use the new version. parking_lot is not using try_reserve so it can live with 1.0.
|
@Amanieu if you could do a dot-release with this change it'd be amazing. I checked 1.0.0 builds parking-lot just fine. |
|
Can't you fix the performance regression in smallvec itself? |
|
Yes, and I intend to do that. But we're about to cut a release and this seemed harmless in your side and avoids me having to patch smallvec to revert the offending patch for now. |
|
Published parking_lot_core 0.8.1. |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smallvec 1.4 regresses performance in Firefox, so while we fix it it'd
be nice to be able to not use the new version. parking_lot is not using
try_reserve so it can live with 1.0.