Skip to content

Fix required lock_api version #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

palana
Copy link
Contributor

@palana palana commented Apr 10, 2020

As of c20495b the additions to lock_api in a9961d4 are required to build parking_lot; building with lock_api 0.3.{1,2,3} fails due to missing _::const_new functions

As of Amanieu@c20495b
the additions to lock_api in Amanieu@a9961d4
are required to build parking_lot; building with lock_api 0.3.{1,2,3}
fails due to missing `_::const_new` functions
@Amanieu
Copy link
Owner

Amanieu commented Apr 10, 2020

Can you update the parking_lot_core version as well while we're at it?

@palana
Copy link
Contributor Author

palana commented Apr 10, 2020

Sure; I couldn't quite tell whether the new parking_lot_core version was required, things seem to work with parking_lot_core 0.7.0, parking_lot 0.10.1 and lock_api 0.3.4

@Amanieu
Copy link
Owner

Amanieu commented Apr 10, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 10, 2020

Build succeeded

@bors bors bot merged commit d070a26 into Amanieu:master Apr 10, 2020
@palana palana deleted the fix-required-lock-api-version branch April 10, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants