Make Once and Condvar constructors const fns #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 18, 2019
134: Make Once and Condvar constructors const fns r=Amanieu a=faern I realized that the `const fn` versions of `Once::new` and `Condvar::new` should now work on all stable releases we support. So more const to the people! Since the next release is going to be a breaking release anyway, I took the liberty of removing `ONCE_INIT` in favor of everyone just using the single constructor. More consistent, and feels more idiomatic. Co-authored-by: Linus Färnstrand <faern@faern.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the
const fnversions ofOnce::newandCondvar::newshould now work on all stable releases we support. So more const to the people!Since the next release is going to be a breaking release anyway, I took the liberty of removing
ONCE_INITin favor of everyone just using the single constructor. More consistent, and feels more idiomatic.