Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rules engine generators fail to import RulesEngineRunnerModule #1789

Open
cpaulve-1A opened this issue May 15, 2024 · 0 comments
Open
Labels
bug Something isn't working triage

Comments

@cpaulve-1A
Copy link
Contributor

Package name

rules-engine

Package version

10.0.3

Reproduction steps

  • Generate a workspace and an application using the @o3r/create generator
  • Add an application with npm run ng g @o3r/workspace:application test.
  • Run npm run ng add @o3r/rules-engine -- --project-name=test.
  • Generate a component using the npm run ng g component my-component command.
  • Convert the component into a rules-engine compatible component with the command npm run ng g rules-engine-to-component -- --path=apps/test/src/components/my-component.component.ts

Current result

The module RulesEngineRunnerModule is neither imported at app nor component level.
image
image

Expected result

The ng add script should add an import of the RulesEngineRunnerService module in the config.ts (or app.module.ts) in the application. This should not be a manual step.

In a similar fashion, the same module should be imported in the component's import list (in the module or the decorator of the module depending on whether the component is standalone or not) when running the npm run ng g rules-engine-to-component command.

Additional comments

No response

@cpaulve-1A cpaulve-1A added bug Something isn't working triage labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

1 participant