Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to create service using the Generator #1778

Closed
gavadhany opened this issue May 14, 2024 · 1 comment
Closed

[Bug]: Unable to create service using the Generator #1778

gavadhany opened this issue May 14, 2024 · 1 comment
Labels
bug Something isn't working triage

Comments

@gavadhany
Copy link
Contributor

Package name

core

Package version

10.2.4

Reproduction steps

Create a simple NX repo
Add o3r/core to the repo
Add an Nx Angular Library for service
Try creating a service in the newly created library using command

"nx generate @o3r/core:service"

Current result

After accepting the inputs, the process hanges

image

Expected result

Service should be created

Additional comments

Did a bit of digging around in the schematics.

It never exits out of the while loop in Index.ts Line 49

image

"tree.exists" isnt working correctly. The third path in the below screenshot exists, but the "tree exists check" is saying false.

image

also path.resolve(destination, rec) !== '/' doesnt work in windows as it ends up returning directory like "C:"
image

Issue appears to be command path.resolve

@gavadhany gavadhany added bug Something isn't working triage labels May 14, 2024
kpanot added a commit that referenced this issue May 17, 2024
…tion (#1782)

## Proposed change
Change path resolver from path.resolve to path.join as the tree.exists
is unable to resolve the absolute path generated by path.resolve

## Related issues

- 🐛 Fixes #1778
@gavadhany
Copy link
Contributor Author

Addressed as a part of #1782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

1 participant