diff --git a/rpc/client/resolver/resolver.go b/rpc/client/resolver/resolver.go index 8cd0552..b90b9e5 100644 --- a/rpc/client/resolver/resolver.go +++ b/rpc/client/resolver/resolver.go @@ -11,7 +11,7 @@ import ( "google.golang.org/grpc/resolver" ) -// "stark_registry:///{service}" +// "stark-registry:///{service}" type builder struct { scheme string selector *atomic.Value diff --git a/rpc/client/selector/registry/registry_selector.go b/rpc/client/selector/registry/registry_selector.go index d7b9b02..f94eeb5 100644 --- a/rpc/client/selector/registry/registry_selector.go +++ b/rpc/client/selector/registry/registry_selector.go @@ -12,7 +12,7 @@ import ( "google.golang.org/grpc/resolver" ) -const scheme = "stark_registry" +const scheme = "stark-registry" var _selector atomic.Value diff --git a/rpc/client/selector/registry/registry_selector_test.go b/rpc/client/selector/registry/registry_selector_test.go index 1b9f595..ed42e9e 100644 --- a/rpc/client/selector/registry/registry_selector_test.go +++ b/rpc/client/selector/registry/registry_selector_test.go @@ -1,6 +1,8 @@ package registry import ( + "fmt" + "net/url" "testing" "github.com/Allenxuxu/stark/rpc/client/selector" @@ -82,3 +84,11 @@ func TestRegistrySelectorFilter(t *testing.T) { assert.Equal(t, service[0].Name, "foo") assert.Equal(t, service[0].Version, version) } + +func Test_schema(t *testing.T) { + _, err := url.Parse(fmt.Sprintf("%s:///%s", "stark_registry", "test")) + assert.Error(t, err) + + _, err = url.Parse(fmt.Sprintf("%s:///%s", "stark-registry", "test")) + assert.NoError(t, err) +} diff --git a/rpc/client/selector/static/static_selector.go b/rpc/client/selector/static/static_selector.go index f9900cf..1838779 100644 --- a/rpc/client/selector/static/static_selector.go +++ b/rpc/client/selector/static/static_selector.go @@ -11,7 +11,7 @@ import ( "google.golang.org/grpc/resolver" ) -const scheme = "stark_static" +const scheme = "stark-static" var _selector atomic.Value