Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds fail with setuptools > 66 #71

Closed
shrik450 opened this issue Apr 3, 2024 · 2 comments
Closed

Builds fail with setuptools > 66 #71

shrik450 opened this issue Apr 3, 2024 · 2 comments

Comments

@shrik450
Copy link
Collaborator

shrik450 commented Apr 3, 2024

We use a template in our build system to fill the version based on the tag:

https://github.com/AllSpiceIO/py-allspice/blob/main/setup.py#L8

Since we don't render the template when installing (e.g. with pip install --editable .), setuptools throws an exception because of pypa/setuptools#2497. This means that e.g. during the dev workflow we have to change the version to a valid PEP440 version and change it back to the template when we're pushing a new release.

@jtran
Copy link
Collaborator

jtran commented May 20, 2024

The template in setup.py was removed in #73. Can this be closed?

@shrik450
Copy link
Collaborator Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants