Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to tokio/hyper with a single thread to conserve resources #29

Open
AlexanderThaller opened this issue Jul 11, 2022 · 0 comments · May be fixed by #38
Open

Switch to tokio/hyper with a single thread to conserve resources #29

AlexanderThaller opened this issue Jul 11, 2022 · 0 comments · May be fixed by #38
Labels
enhancement New feature or request performance Performance enhancement changes that reduce ressource usage question Further information is requested
Milestone
0.9.0

Comments

@AlexanderThaller
Copy link
Owner

To use less threads and therefore less resources we could switch to tokio/hyper with a single thread instead of using tiny-http which will spawn many threads tiny-http/tiny-http#205.

The biggest problem would be how to make this work with the existing interface and how to make it as ergonomic as possible.

Could just be behind a feature flag so it can be used and improved for now. It would also make it easier to use this crate with applications that already use a async framework.
@AlexanderThaller AlexanderThaller added enhancement New feature or request question Further information is requested performance Performance enhancement changes that reduce ressource usage labels Jul 11, 2022
@AlexanderThaller AlexanderThaller mentioned this issue Jul 11, 2022
Closed
@AlexanderThaller AlexanderThaller added this to the v0.9.0 milestone Nov 18, 2022
@AlexanderThaller AlexanderThaller linked a pull request Nov 22, 2022 that will close this issue
Draft
@AlexanderThaller AlexanderThaller linked a pull request Nov 22, 2022 that will close this issue
Start implementing the tokio/hyper version of the crate #38
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance Performance enhancement changes that reduce ressource usage question Further information is requested
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Start implementing the tokio/hyper version of the crate AlexanderThaller/prometheus_exporter
1 participant
@AlexanderThaller