Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] leo execute on-chain option #361

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

evan-schott
Copy link
Contributor

Execute a leo function on-chain

@evan-schott evan-schott requested a review from d0cd April 26, 2024 21:23
Copy link
Contributor

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a rewording, since we don't actually execute transitions on-chain like Ethereum: we execute off-chain, generate a ZK proof, and verify the ZK proof on-chain. Perhaps there's a better wording than I suggested, but it gets to the gist of it.

@d0cd d0cd changed the base branch from master to fix/leo-deploy April 29, 2024 15:15
Co-authored-by: Alessandro Coglio <2409151+acoglio@users.noreply.github.com>
Signed-off-by: evan-schott <53463459+evan-schott@users.noreply.github.com>
Base automatically changed from fix/leo-deploy to master May 7, 2024 15:20
@d0cd
Copy link
Contributor

d0cd commented May 7, 2024

@evan-schott Does this need to be updated after the feedback from code review?

[Fix] Correct `hello.leo` walkthrough
@evan-schott evan-schott requested a review from acoglio May 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants