New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce magic numbers to prevent stack overflow in wasm call to bhp #455

Merged

amousa11 merged 1 commit into testnet2 from fix/wasm-bhp-stack-overflow

Oct 22, 2021

Contributor

amousa11 commented Oct 22, 2021

BHP commit makes an absolutely insane stack allocation that needed to be trimmed down for it to work properly in wasm.


          fix: reduce magic numbers to prevent stack overflow in wasm call to bhp

9adf0a3

amousa11 requested review from howardwu and collinc97

October 22, 2021 00:29

collinc97 approved these changes

View reviewed changes

howardwu approved these changes

View reviewed changes

Member

howardwu left a comment

LGTM, for next steps, we can remove these magical constants

amousa11 merged commit a4f01d1 into testnet2

amousa11 deleted the fix/wasm-bhp-stack-overflow branch

October 22, 2021 06:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment