Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds serialize and deserialize to Network types #450

Merged
merged 17 commits into from Oct 20, 2021
Merged

Adds serialize and deserialize to Network types #450

merged 17 commits into from Oct 20, 2021

Conversation

howardwu
Copy link
Member

@howardwu howardwu commented Oct 16, 2021 •
edited

Motivation

  • Adds Serialize and Deserialize to Network types
  • Moves tests_field.rs to snarkvm-curves, simplifying Cargo dependencies
  • Moves events from Transition to Transaction, enabling Transition to be a fixed size struct

Test Plan

  • Adds test_serde_json and test_bincode methods to structs implementing serialization

@howardwu howardwu marked this pull request as ready for review October 18, 2021 11:38
@howardwu howardwu requested review from amousa11, raychu86 and collinc97 and removed request for amousa11 October 18, 2021 11:38
@howardwu howardwu merged commit 0178f34 into testnet2 Oct 20, 2021
@howardwu howardwu deleted the feat/serialize branch October 20, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raychu86 raychu86 raychu86 approved these changes

@collinc97 collinc97 collinc97 approved these changes

@amousa11 amousa11 Awaiting requested review from amousa11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@howardwu @raychu86 @collinc97