New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] Upgrade structs, remove duplication, refactor codebase, improve ergonomics #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 92.70% 92.91% +0.20%
==========================================
Files 72 63 -9
Lines 2770 2696 -74
==========================================
- Hits 2568 2505 -63
+ Misses 202 191 -11
Continue to review full report at Codecov.
|
…nto feat/marlin-snark-standard
Implement Snark standards for Marlin
Isolate integer and bits gadgets out of the traits::utilities module
Migrate `snarkvm-nonnative` to `snarkvm-gadgets::nonnative`
Migrate `snarkvm-objects` to `snarkvm-dpc::block`
This was referenced Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade struct conventions, remove duplication, improve ergonomics.
Merged changes:
SNARKVerificationGadget
trait for the Marlin verification gadgetsnarkvm-nonnative
tosnarkvm-gadgets::nonnative
#188) Migratesnarkvm-nonnative
tosnarkvm-gadgets::nonnative
snarkvm-objects
tosnarkvm-dpc::block
#189) Migratesnarkvm-objects
tosnarkvm-dpc::block
General changes:
dpc/src/base_dpc
todpc/src/testnet1
Assignment
trait indpc/src/lib.rs
snarkos-integration
to.snarkos-integration
and include in workspace for testingTrait changes:
Program
toProgramScheme
Record
toRecordScheme
Transaction
toTransactionScheme
RecordSerializerScheme
toRecordEncodingScheme
SNARK
internal types fromAssignedCircuit
toAllocatedCircuit
,PreparedVerifcationParameters
toPreparedVerifyingKey
,Parameters
toProvingKey
, andVerificationParameters
toVerifyingKey
Struct changes:
DPCRecord
toRecord
DPCTransaction
toTransaction
DPCTransactions
toTransactions
RecordSerializer
toRecordEncoding
, and renames internal methodsserialize
toencode
anddeserialize
todecode
DeserializedRecord
toDecodedRecord
Parameters
toProvingKey
forsnarkos-algorithms/snark
RecordPayload
toPayload
AleoAmount
fromsnarkvm-objects
tosnarkvm-dpc
AmountError
Parameter changes:
global/
andtestnet1/
directoriesInnerSNARKID
toInnerCircuitID
,InnerSNARKVerificationKeyCRH
toInnerCircuitIDCRH
,inner_snark_verification_key_crh
toinner_circuit_id_crh
, andinner_snark_vk_crh
toinner_circuit_id_crh