New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option to add a comment to every select's option #418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight forward implementation and works as expected - nice!
Will merge this in once we get the 👍 from GH
@luanraithz the tests are failing - mind fixing them? |
Sorry, didn't see that. I'm on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this feature! Thanks for adding it.
examples/meals.go
Outdated
@@ -0,0 +1,53 @@ | |||
package main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the file meals.go
be named something more descriptive of the feature it's demoing, such as select_description.go
?
I think it's all solved, thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@AlecAivazis How soon can we expect a release with this PR? |
Thanks for the ping! It's now been released as |
This is the pull request mentioned on #416