fix cursor updating in windows #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlecAivazis I know you've been busy, but if you're able to get this in soon, we'd really appreciate it. We're hoping to get a new version bump into GitHub CLI as soon as you're comfortable so the accessibility improvements are available to all our users. |
|
Ah, darn! Thanks for the quick fix! |
AlecAivazis
approved these changes
Aug 23, 2021
|
This is now released in |
|
Omg @AlecAivazis that's amazing, thank you SO much. ❤️ ✨ |
|
thank you!!! sorry for the hassle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr cursor was not updating in windows; this fixes it (tested with NVDA)
long version: i noticed that the argument to
PreviousLinewas unused; I mindlessly made it-1as a mental TODO to investigate why it took a parameter at all. I realized that the parameter was used in the windows version of the cursor code, but apparently didn't go back and fix the argument (I totally thought I had and I'm not sure what happened since I did do windows QA at some point and it worked).