This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Validators for the number of responses in multiselect #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry i haven't gotten to this yet @MAD-py. work was really busy this week, will try to find some time to look at it over the weekend |
|
@AlecAivazis no problem. Actually I had a pretty busy week too. |
AlecAivazis
suggested changes
Jul 15, 2021
There was a problem hiding this comment.
Overall this looks pretty good - thanks for adding some tests. Do you mind adding something in the README? Also, I'm open to adding a bunch more validators, they're pretty harmless to throw into a survey/validators directory but we can do that in a separate PR
|
hi @AlecAivazis I've already added the validators info in the README, I'll be working on more validators that are useful for the API and in a while I'll be doing the corresponding PR. |
|
Thanks for doing that! I'll merge this in once github gives us the 👍 |
AlecAivazis
approved these changes
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a more complete API and remove worries to the user, I propose to add a series of validators that can make things easier for the user, at this moment I only propose two very simple validators to validate the maximum and minimum of selected answers in a multiselect.
I would like to know what do you think about the proposal and if it is possible to make more validators that can be useful.
Personally I would like to have a number of validators similar to the Pydantic library of python.