Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

(fix): problems with input navegation #361

Merged
merged 9 commits into from Jul 2, 2021
Merged

(fix): problems with input navegation #361

merged 9 commits into from Jul 2, 2021

Conversation

lucassabreu
Copy link
Contributor

  • first pass at input using RuneReader.ReadLine with suggestions
  • fix newline from readline
  • better callback name

@lucassabreu lucassabreu force-pushed the input-readline-with-suggestions branch 2 times, most recently from 6e10ece to fa313ed Compare June 29, 2021 00:33
@lucassabreu lucassabreu mentioned this pull request Jun 29, 2021
Merged
@lucassabreu lucassabreu marked this pull request as ready for review June 29, 2021 02:01
@lucassabreu lucassabreu force-pushed the input-readline-with-suggestions branch from e50e421 to 2bbbbea Compare June 29, 2021 02:32
@lucassabreu
Copy link
Contributor Author

@AlecAivazis i think it's done, but there is a error on Ubuntu, you know what it is?

@AlecAivazis
Copy link
Owner

AlecAivazis commented Jun 29, 2021 •
edited

Thanks for getting this through! I'll take a look at the code some time today. It looks like the test on survey_test.go:249 is hanging

@lucassabreu lucassabreu force-pushed the input-readline-with-suggestions branch 3 times, most recently from 96005b6 to 959b32a Compare June 29, 2021 18:19
@lucassabreu lucassabreu force-pushed the input-readline-with-suggestions branch from 959b32a to 62afa3b Compare June 29, 2021 18:32
@lucassabreu
Copy link
Contributor Author

fixed the hanging looks like some problem with using i on vi in the actions... changed all to cc.

it also fixed the compatibility problem with my vim when i did that.

@AlecAivazis
Copy link
Owner

Nice!! I'll find some time today to test this 👍

AlecAivazis
AlecAivazis reviewed Jun 30, 2021
View reviewed changes
Copy link
Owner

@AlecAivazis AlecAivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down the changes and they behave perfectly. It was very satisfying to press the arrow key in the middle of suggestions and then fix the value. Overall a very smooth experience. A little question about the help behavior and then all that should be left is to review the actual code. I've been looking over it periodically and it seems good, just want to give it a final once-over.

thanks again!

input.go Show resolved Hide resolved
@lucassabreu lucassabreu force-pushed the input-readline-with-suggestions branch from 76af29d to 62afa3b Compare June 30, 2021 18:02
AlecAivazis
AlecAivazis approved these changes Jul 2, 2021
View reviewed changes
Copy link
Owner

@AlecAivazis AlecAivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go! I pulled it down and tested the changes on iTerm2 for mac , as well as cmd.exe and the Ubuntu terminal on windows. Thanks for getting this out so quickly @lucassabreu

@AlecAivazis AlecAivazis merged commit 3ec04a9 into AlecAivazis:master Jul 2, 2021
@AlecAivazis
Copy link
Owner

This is now published under v2.2.14

@lucassabreu lucassabreu deleted the input-readline-with-suggestions branch July 2, 2021 20:39
@nhatthm nhatthm mentioned this pull request Sep 22, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlecAivazis AlecAivazis AlecAivazis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucassabreu @AlecAivazis