This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Re-enable TestAsk #354
Merged
Re-enable TestAsk #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have been disabled since AlecAivazis#216. Co-authored-by: Boris Od <borod108@users.noreply.github.com>
|
@AlecAivazis please review. |
|
Thanks for hunting this down @cben! |
AlecAivazis
approved these changes
May 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those got disabled in https://github.com/AlecAivazis/survey/pull/216/files#diff-3a029c8ea50304c9dc5637560df2375bc28f1620d72744a13f4d3c152bb16a4aR120 and apparently were forgotten since then?
I noticed several tests, some here and some in other files, sometimes get stuck when running
go test -v.Everything works reliably without
-v, so I guess there are timing issues due to verbose printing; but when focusing on a single test with-run=REGEXPthey also work pretty reliably even with-v.-v, and I don't know how to debug it (-vdoesn't help — it doesn't get to show "raw output" which is usually very helpful).