Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Use rune when delete or filter answer #327

Merged
merged 5 commits into from Feb 23, 2021
Merged

Use rune when delete or filter answer #327

merged 5 commits into from Feb 23, 2021

Conversation

AielloChan
Copy link
Contributor

When using Unicode in the string type answer will cause a problem.

Example:

> go run examples/simple.go
? What is your name? 小明

@AlecAivazis
Copy link
Owner

Hey @AielloChan! Thanks for submitting this fix, would you mind adding a test that shows the problem is fixed?

@AielloChan
Copy link
Contributor Author

Check if that is ok😬

@AlecAivazis
Copy link
Owner

AlecAivazis commented Feb 22, 2021

Okay, I finally found some time to pull this down and give it a shot. Thanks for being patient!

Everything seems to behave correctly on my machine, however since this touches a bunch of prompts, i'd like to get a second pair of eyes on it. Maybe @coryb or @mislav have some spare time?

@AlecAivazis
Copy link
Owner

Hm, I might be missing something but wouldn't this also affect the Select prompt?

@AielloChan
Copy link
Contributor Author

Hm, I might be missing something but wouldn't this also affect the Select prompt?

Yes, because prompt filter also need use Rune for unicode words.

Copy link
Collaborator

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@AlecAivazis
Copy link
Owner

great! thanks for taking a look @mislav

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants