Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

add an option to hide password #249

Closed
axetroy opened this issue Aug 25, 2019 · 7 comments
Closed

add an option to hide password #249

axetroy opened this issue Aug 25, 2019 · 7 comments

Comments

@axetroy
Copy link

axetroy commented Aug 25, 2019

Entering passwords under Unix is invisible, which is also for security reasons.

@MarkusFreitag
Copy link
Contributor

Hi axetroy,
could you please provide a bit more context? There is already a component for password inputs https://github.com/AlecAivazis/survey#password

@axetroy
Copy link
Author

axetroy commented Aug 26, 2019

@MarkusFreitag

By default, the password input box should be hidden.

This behavior is consistent with the password input of unix

@MarkusFreitag
Copy link
Contributor

Ah, you mean that also the "star" placeholder chars should be hidden?

@axetroy
Copy link
Author

axetroy commented Aug 26, 2019

@MarkusFreitag
yes. This is to prevent the password length from being known by others, thus violently cracking.

@MarkusFreitag
Copy link
Contributor

Yeah, I totally understand your point.
@AlecAivazis What do you think?

@AlecAivazis
Copy link
Owner

Hey @axetroy - thanks for the submission. I appreciate your desire to make survey as secure as possible. I spent a good amount of time looking at discussions online for this and came to the conclusion that it is a false sense of security since someone who is careful enough to quickly count the number of letters you typed would also be able to hear your keyboard or any number of other ways to get your password.

This password prompt has been designed this way for a few years now without anyone saying anything. If you feel as if this is crucial for your product, you should be able to make a custom Prompt that does not show the input. If you need help doing so, feel free to reach out.

@szh
Copy link

szh commented Apr 3, 2023

This would be solved in #482

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants