Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Vows to smart-wallet #9308

Open
turadg opened this issue Apr 30, 2024 · 0 comments
Open

add support for Vows to smart-wallet #9308

turadg opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Apr 30, 2024

What is the Problem Being Solved?

Currently when an OfferResult is a promise, smartWallet awaits it with watchPromise to record the offer result.

/**
* @param {OutcomeWatchers} watchers
* @param {UserSeat} seat
*/
const watchForOfferResult = ({ resultWatcher }, seat) => {
const p = E(seat).getOfferResult();
watchPromise(p, resultWatcher, seat);
return p;
};

Description of the Design

We could use watch in VowTools in place of the current watchPromises.

We might want to go further and use asyncFlow to refactor much of the smart wallet state handling.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg added the enhancement New feature or request label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant