Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely refact the way subscriptions are managed #66

Open
Aerendir opened this issue Sep 9, 2020 · 0 comments
Open

Completely refact the way subscriptions are managed #66

Aerendir opened this issue Sep 9, 2020 · 0 comments

Comments

@Aerendir
Copy link
Owner

Aerendir commented Sep 9, 2020

Currently all the configured features are created in a subscription.

But this is not flexible as it doesn't permit to add or remove features and their prices.

Instead, we should save in the subscription a snapshot of the current configuration.

This way, when a new feature is added, if it is not present in the subscription, then it is not available to the user.

The problem is with the features that are in the subscription but are not in the configuration anymore: they are subscribed by the user, but in the code we cannot get them as they are not configured anymore (doing something like ->get('ads')->getInstantPrice('EUR', 'monthly') will not work if the feature ads is in the subscription but is not in the configuration).

So, we need to find a way to:

  1. Maintain features in the subscription also if they aren't in the configuration anymore;
  2. Deprecate old features (maybe to rename them)
  3. Create a command to update current subscriptions.

This is linked to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant