Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too strict parsing of tsconfig.json #11

Closed
perbergland opened this issue Apr 17, 2019 · 5 comments
Closed

Too strict parsing of tsconfig.json #11

perbergland opened this issue Apr 17, 2019 · 5 comments

Comments

@perbergland
Copy link
Collaborator

perbergland commented Apr 17, 2019

The parser crashes when encountering sections it doesn't know about - I would prefer if it passed through all options to tsc to avoid needing to update the module whenever MS introduces a new setting.

Example - https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html:

"compilerOptions": { 
    "incremental": true
},

   packages/adornis:typescript-compiler/typescript-compiler.js:327:13: Format of the tsconfig is invalid: Error: Unknown compiler option 'compilerOptions'.
   at TypeScriptCompiler._parseConfig (packages/adornis:typescript-compiler/typescript-compiler.js:327:13)

@perbergland
Copy link
Collaborator Author

nevermind I goofed up

@yorrd
Copy link
Member

yorrd commented Apr 17, 2019

😄 youre working on incremental! Amazing 🎉

@yorrd
Copy link
Member

yorrd commented Apr 20, 2019

do we need to wait for this? just stumbled on it while doing something else

microsoft/TypeScript#29978

@perbergland
Copy link
Collaborator Author

I added
"incremental": true
to my tsconfig.json file and it seems to just work (I have tested in watch mode for meteor test and meteor run). No further work needed unless you want to make it a default setting.

@yorrd
Copy link
Member

yorrd commented Apr 20, 2019

how do you make sure it's actually running incrementally? Might that just be the old barbatus cache?

Where is your .tsbuildinfo-file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants