Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at flake8 B028 #553

Open
enzbang opened this issue Jan 16, 2023 · 0 comments
Open

Look at flake8 B028 #553

enzbang opened this issue Jan 16, 2023 · 0 comments
Labels
good first issue Small task that can be performed by new or casual contributors

Comments

@enzbang
Copy link
Member

enzbang commented Jan 16, 2023

Flake8 flags some code with the B028 check:

B028: Consider replacing f"'{foo}'" with f"{foo!r}" which is both easier to read and will escape quotes inside foo if that would appear. The check tries to filter out any format specs that are invalid together with !r. If you're using other conversion flags then e.g. f"'{foo!a}'" can be replaced with f"{ascii(foo)!r}". Not currently implemented for python<3.8 or str.format() calls.

Code should be rewritten following that advice or we should make the decision to ignore that warning.

@enzbang enzbang added the good first issue Small task that can be performed by new or casual contributors label Jan 16, 2023
enzbang added a commit to enzbang/e3-core that referenced this issue Jan 16, 2023
Nikokrock pushed a commit to Nikokrock/e3-core that referenced this issue Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Small task that can be performed by new or casual contributors
Projects
None yet
Development

No branches or pull requests

1 participant