Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlimit binaries? really? #388

Open
jrmarino opened this issue May 30, 2020 · 2 comments
Open

rlimit binaries? really? #388

jrmarino opened this issue May 30, 2020 · 2 comments
Labels
good first issue Small task that can be performed by new or casual contributors

Comments

@jrmarino
Copy link

It seems someone has prebuilt rlimit for several platforms and installs them as binaries as part of a python package. It should go without saying this is unconventional. Not to mention, it obviously doesn't cover every platform. The 4 major BSD systems for starters.

Why isn't rlimit being built from source by the module priority to installation?

I found this issue because the build failed sanity checks -- e.g. there are libraries linked by these rlimit libraries that obviously are not present on the host system.

This is not a good approach. If you need an rlimit binary, then build it in real time so it's guaranteed to be available for the host platform.

I've honestly never seen this approach before.

@jrmarino
Copy link
Author

jrmarino commented May 30, 2020

To package this I had to delete all the pre-packaged binaries and build a new one named src/e3/tools/rlimit-[lowercase-platform] from the rlimit.c source file.

@enzbang
Copy link
Member

enzbang commented Jun 1, 2020

Hi @jrmarino

I understand that what is currently done is not appropriate for unsupported platforms. We want to avoid the need of the compiler when building e3-core, in particular to make it easy to support windows. We'll try to find a solution to that issue.

@enzbang enzbang added the good first issue Small task that can be performed by new or casual contributors label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Small task that can be performed by new or casual contributors
Projects
None yet
Development

No branches or pull requests

2 participants