Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e3.net.http.HTTPSession base_urls should never be None #354

Open
enzbang opened this issue Mar 19, 2020 · 0 comments
Open

e3.net.http.HTTPSession base_urls should never be None #354

enzbang opened this issue Mar 19, 2020 · 0 comments
Labels
good first issue Small task that can be performed by new or casual contributors

Comments

@enzbang
Copy link
Member

enzbang commented Mar 19, 2020

The code in HTTPSession is very complex and some methods won't work when base_urls is not set. When base_urls is not set the callers are most of the time only using the download_file function. We should create a new download_file function that does not depend on HTTPSession.
@enzbang enzbang added the good first issue Small task that can be performed by new or casual contributors label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Small task that can be performed by new or casual contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enzbang