diff --git a/CHANGELOG.txt b/CHANGELOG.txt index b49f25d..6a7a290 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -7,6 +7,11 @@ Version 4.3 - released 2020-06-12 Version 4.3 is almost a re-tagged release of version 4.0. It is the last to support Python 2.7. This is now made explicit in the `python_requires` argument in `setup.py`. Python 3.4 is not supported by this release. +- Fix #165: CVE-2020-25658 - Bleichenbacher-style timing oracle in PKCS#1 v1.5 + decryption code + + +## Version 4.4 & 4.6 - released 2020-06-12 Two security fixes have also been backported, so 4.3 = 4.0 + these two fixes. diff --git a/rsa/pkcs1.py b/rsa/pkcs1.py index c05239a..60360dc 100644 --- a/rsa/pkcs1.py +++ b/rsa/pkcs1.py @@ -30,6 +30,9 @@ import hashlib import os +import sys +import typing +from hmac import compare_digest from rsa._compat import range from rsa import common, transform, core @@ -237,17 +240,20 @@ def decrypt(crypto, priv_key): # Detect leading zeroes in the crypto. These are not reflected in the # encrypted value (as leading zeroes do not influence the value of an # integer). This fixes CVE-2020-13757. - if len(crypto) > blocksize: - raise DecryptionError('Decryption failed') + crypto_len_bad = len(crypto) > blocksize # If we can't find the cleartext marker, decryption failed. - if cleartext[0:2] != b'\x00\x02': - raise DecryptionError('Decryption failed') + cleartext_marker_bad = not compare_digest(cleartext[:2], b'\x00\x02') # Find the 00 separator between the padding and the message try: sep_idx = cleartext.index(b'\x00', 2) except ValueError: + sep_idx = -1 + sep_idx_bad = sep_idx < 0 + + anything_bad = crypto_len_bad | cleartext_marker_bad | sep_idx_bad + if anything_bad: raise DecryptionError('Decryption failed') return cleartext[sep_idx + 1:]